Trjtdtk

Benefits of using sObject.clone versus creating a new record

SF book about people trapped in a series of worlds they imagine

What is the effect of altitude on true airspeed?

Is there hard evidence that the grant peer review system performs significantly better than random?

How do I use the new nonlinear finite element in Mathematica 12 for this equation?

Using et al. for a last / senior author rather than for a first author

How do I make this wiring inside cabinet safer?

How to Make a Beautiful Stacked 3D Plot

Significance of Cersei's obsession with elephants?

NumericArray versus PackedArray in MMA12

Are all finite dimensional hilbert spaces isomorphic to spaces with Euclidean norms?

What is the meaning of the simile “quick as silk”?

Can a new player join a group only when a new campaign starts?

Dating a Former Employee

How to tell that you are a giant?

Is grep documentation about ignoring case wrong, since it doesn't ignore case in filenames?

Disembodied hand growing fangs

What does this Jacques Hadamard quote mean?

AppleTVs create a chatty alternate WiFi network

The logistics of corpse disposal

Is it fair for a professor to grade us on the possession of past papers?

Fundamental Solution of the Pell Equation

Why do we bend a book to keep it straight?

What's the meaning of "fortified infraction restraint"?

Check for characters in a string being unique

.everyoneloves__top-leaderboard:empty,.everyoneloves__mid-leaderboard:empty,.everyoneloves__bot-mid-leaderboard:empty height:90px;width:728px;box-sizing:border-box;

8

1

I implemented my algorithm for checking if the string passed in is unique. I feel like my algorithm is correct, but obviously in certain cases it gives the wrong results. Why?

function isUnique(str) 
 let sortedArr = str.split('').sort();
 for (let [i, char] of sortedArr.entries()) 
 if (char === sortedArr[i + 1]) 
 return false
 else 
 return true
 
 


console.log(isUnique('heloworld')) // true

javascript

share|improve this question

edited Apr 3 at 11:13

Peter Mortensen

13.9k1987114

asked Apr 3 at 5:35

user3763875user3763875

745

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  FWIW: function noDuplicatedChars() const chars = new Set(); for (let c of str) if (chars.has(c)) return false; chars.add(c); return true; is a faster alternative.
  
  – Frax
  Apr 3 at 5:55
  

  
  
  
  

add a comment | 

8

1

I implemented my algorithm for checking if the string passed in is unique. I feel like my algorithm is correct, but obviously in certain cases it gives the wrong results. Why?

function isUnique(str) 
 let sortedArr = str.split('').sort();
 for (let [i, char] of sortedArr.entries()) 
 if (char === sortedArr[i + 1]) 
 return false
 else 
 return true
 
 


console.log(isUnique('heloworld')) // true

javascript

share|improve this question

edited Apr 3 at 11:13

Peter Mortensen

13.9k1987114

asked Apr 3 at 5:35

user3763875user3763875

745

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  FWIW: function noDuplicatedChars() const chars = new Set(); for (let c of str) if (chars.has(c)) return false; chars.add(c); return true; is a faster alternative.
  
  – Frax
  Apr 3 at 5:55
  

  
  
  
  

add a comment | 

I implemented my algorithm for checking if the string passed in is unique. I feel like my algorithm is correct, but obviously in certain cases it gives the wrong results. Why?

function isUnique(str) 
 let sortedArr = str.split('').sort();
 for (let [i, char] of sortedArr.entries()) 
 if (char === sortedArr[i + 1]) 
 return false
 else 
 return true
 
 


console.log(isUnique('heloworld')) // true

javascript

share|improve this question

edited Apr 3 at 11:13

Peter Mortensen

13.9k1987114

asked Apr 3 at 5:35

user3763875user3763875

745

function isUnique(str) 
 let sortedArr = str.split('').sort();
 for (let [i, char] of sortedArr.entries()) 
 if (char === sortedArr[i + 1]) 
 return false
 else 
 return true
 
 


console.log(isUnique('heloworld')) // true

function isUnique(str) 
 let sortedArr = str.split('').sort();
 for (let [i, char] of sortedArr.entries()) 
 if (char === sortedArr[i + 1]) 
 return false
 else 
 return true
 
 


console.log(isUnique('heloworld')) // true

function isUnique(str) 
 let sortedArr = str.split('').sort();
 for (let [i, char] of sortedArr.entries()) 
 if (char === sortedArr[i + 1]) 
 return false
 else 
 return true
 
 


console.log(isUnique('heloworld')) // true

share|improve this question

edited Apr 3 at 11:13

Peter Mortensen

13.9k1987114

asked Apr 3 at 5:35

user3763875user3763875

745

share|improve this question

edited Apr 3 at 11:13

Peter Mortensen

13.9k1987114

asked Apr 3 at 5:35

user3763875user3763875

745

edited Apr 3 at 11:13

Peter Mortensen

13.9k1987114

edited Apr 3 at 11:13

Peter Mortensen

13.9k1987114

asked Apr 3 at 5:35

user3763875user3763875

745

asked Apr 3 at 5:35

user3763875user3763875

745

2 Answers
2

active

oldest

votes

25

return immediately terminates the function, so only the first iteration if your for loop will ever run. Instead, you should check for whether all characters are unique (if not, return false inside the loop), else return true after the end of the loop:

function isUnique(str) 
 let sortedArr = str.split('').sort();
 for(let [i,char] of sortedArr.entries()) 
 if(char === sortedArr[i + 1]) 
 return false
 
 
 return true


console.log(isUnique('heloworld'))

But it would probably be a lot easier to use a Set, and see if its size is equal to the length of the string:

function isUnique(str) 
 return new Set(str).size === str.length;


console.log(isUnique('heloworld'))
console.log(isUnique('abc'))

See comment, thanks Patrick: if you need to account for characters composed of multiple UCS-2 code points (𝟙𝟚𝟛😎😜🙃 etc), call the string iterator and check how many items it returns, which can be done with spread or Array.from (because otherwise, str.length won't evaluate to the right number of individual characters):

function isUnique(str) 
 return new Set(str).size === [...str].length;


console.log(isUnique('😜'));
console.log(isUnique('😜😜'));

share|improve this answer

edited Apr 3 at 6:03

Patrick Roberts

21.3k33777

answered Apr 3 at 5:37

CertainPerformanceCertainPerformance

100k166291

• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  Not sure if this matters but for multi-unit code points you get the wrong answer, e.g. isUnique('😀😁') === false
  
  – Patrick Roberts
  Apr 3 at 5:42
  
  

  
  
  
  


• 
  
  
  

  
  5
  

  
  
  
  
  
  

  
  
  The fix is relatively simple though: return new Set(str).size === Array.from(str).length;
  
  – Patrick Roberts
  Apr 3 at 5:50
  

  
  
  
  

add a comment | 

0

Only first iteration in your for loop is run (because you always execute 'return'). Instead you can use following code

function isUnique(str, t=) 
 
 return ![...str].some(c=> t[c]=c in t)


console.log('heloworld =>',isUnique('heloworld'));
console.log('helo =>',isUnique('helo'));

share|improve this answer

edited Apr 3 at 8:07

answered Apr 3 at 5:52

Kamil KiełczewskiKamil Kiełczewski

14.5k87397

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  Why is r a parameter?
  
  – JollyJoker
  Apr 3 at 8:01
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  r (I rename it to t) is temporary hash map (define in tricky way as default param)
  
  – Kamil Kiełczewski
  Apr 3 at 8:07
  
  

  
  
  
  

add a comment | 

Your Answer

StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");

StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "1"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);

else
createEditor();

);

function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: true,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: 10,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);



);

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);

Sign up using Google

Sign up using Facebook

Sign up using Email and Password

Post as a guest

Name

Email

Required, but never shown

StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fstackoverflow.com%2fquestions%2f55487722%2fcheck-for-characters-in-a-string-being-unique%23new-answer', 'question_page');

);

Post as a guest

Name

Email

Required, but never shown

25

return immediately terminates the function, so only the first iteration if your for loop will ever run. Instead, you should check for whether all characters are unique (if not, return false inside the loop), else return true after the end of the loop:

function isUnique(str) 
 let sortedArr = str.split('').sort();
 for(let [i,char] of sortedArr.entries()) 
 if(char === sortedArr[i + 1]) 
 return false
 
 
 return true


console.log(isUnique('heloworld'))

But it would probably be a lot easier to use a Set, and see if its size is equal to the length of the string:

function isUnique(str) 
 return new Set(str).size === str.length;


console.log(isUnique('heloworld'))
console.log(isUnique('abc'))

See comment, thanks Patrick: if you need to account for characters composed of multiple UCS-2 code points (𝟙𝟚𝟛😎😜🙃 etc), call the string iterator and check how many items it returns, which can be done with spread or Array.from (because otherwise, str.length won't evaluate to the right number of individual characters):

function isUnique(str) 
 return new Set(str).size === [...str].length;


console.log(isUnique('😜'));
console.log(isUnique('😜😜'));

share|improve this answer

edited Apr 3 at 6:03

Patrick Roberts

21.3k33777

answered Apr 3 at 5:37

CertainPerformanceCertainPerformance

100k166291

• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  Not sure if this matters but for multi-unit code points you get the wrong answer, e.g. isUnique('😀😁') === false
  
  – Patrick Roberts
  Apr 3 at 5:42
  
  

  
  
  
  


• 
  
  
  

  
  5
  

  
  
  
  
  
  

  
  
  The fix is relatively simple though: return new Set(str).size === Array.from(str).length;
  
  – Patrick Roberts
  Apr 3 at 5:50
  

  
  
  
  

add a comment | 

25

return immediately terminates the function, so only the first iteration if your for loop will ever run. Instead, you should check for whether all characters are unique (if not, return false inside the loop), else return true after the end of the loop:

function isUnique(str) 
 let sortedArr = str.split('').sort();
 for(let [i,char] of sortedArr.entries()) 
 if(char === sortedArr[i + 1]) 
 return false
 
 
 return true


console.log(isUnique('heloworld'))

But it would probably be a lot easier to use a Set, and see if its size is equal to the length of the string:

function isUnique(str) 
 return new Set(str).size === str.length;


console.log(isUnique('heloworld'))
console.log(isUnique('abc'))

See comment, thanks Patrick: if you need to account for characters composed of multiple UCS-2 code points (𝟙𝟚𝟛😎😜🙃 etc), call the string iterator and check how many items it returns, which can be done with spread or Array.from (because otherwise, str.length won't evaluate to the right number of individual characters):

function isUnique(str) 
 return new Set(str).size === [...str].length;


console.log(isUnique('😜'));
console.log(isUnique('😜😜'));

share|improve this answer

edited Apr 3 at 6:03

Patrick Roberts

21.3k33777

answered Apr 3 at 5:37

CertainPerformanceCertainPerformance

100k166291

• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  
  Not sure if this matters but for multi-unit code points you get the wrong answer, e.g. isUnique('😀😁') === false
  
  – Patrick Roberts
  Apr 3 at 5:42
  
  

  
  
  
  


• 
  
  
  

  
  5
  

  
  
  
  
  
  

  
  
  The fix is relatively simple though: return new Set(str).size === Array.from(str).length;
  
  – Patrick Roberts
  Apr 3 at 5:50
  

  
  
  
  

add a comment | 

return immediately terminates the function, so only the first iteration if your for loop will ever run. Instead, you should check for whether all characters are unique (if not, return false inside the loop), else return true after the end of the loop:

function isUnique(str) 
 let sortedArr = str.split('').sort();
 for(let [i,char] of sortedArr.entries()) 
 if(char === sortedArr[i + 1]) 
 return false
 
 
 return true


console.log(isUnique('heloworld'))

But it would probably be a lot easier to use a Set, and see if its size is equal to the length of the string:

function isUnique(str) 
 return new Set(str).size === str.length;


console.log(isUnique('heloworld'))
console.log(isUnique('abc'))

See comment, thanks Patrick: if you need to account for characters composed of multiple UCS-2 code points (𝟙𝟚𝟛😎😜🙃 etc), call the string iterator and check how many items it returns, which can be done with spread or Array.from (because otherwise, str.length won't evaluate to the right number of individual characters):

function isUnique(str) 
 return new Set(str).size === [...str].length;


console.log(isUnique('😜'));
console.log(isUnique('😜😜'));

share|improve this answer

edited Apr 3 at 6:03

Patrick Roberts

21.3k33777

answered Apr 3 at 5:37

CertainPerformanceCertainPerformance

100k166291

function isUnique(str) 
 let sortedArr = str.split('').sort();
 for(let [i,char] of sortedArr.entries()) 
 if(char === sortedArr[i + 1]) 
 return false
 
 
 return true


console.log(isUnique('heloworld'))

function isUnique(str) 
 return new Set(str).size === str.length;


console.log(isUnique('heloworld'))
console.log(isUnique('abc'))

function isUnique(str) 
 return new Set(str).size === [...str].length;


console.log(isUnique('😜'));
console.log(isUnique('😜😜'));

function isUnique(str) 
 let sortedArr = str.split('').sort();
 for(let [i,char] of sortedArr.entries()) 
 if(char === sortedArr[i + 1]) 
 return false
 
 
 return true


console.log(isUnique('heloworld'))

function isUnique(str) 
 let sortedArr = str.split('').sort();
 for(let [i,char] of sortedArr.entries()) 
 if(char === sortedArr[i + 1]) 
 return false
 
 
 return true


console.log(isUnique('heloworld'))

function isUnique(str) 
 return new Set(str).size === str.length;


console.log(isUnique('heloworld'))
console.log(isUnique('abc'))

function isUnique(str) 
 return new Set(str).size === str.length;


console.log(isUnique('heloworld'))
console.log(isUnique('abc'))

function isUnique(str) 
 return new Set(str).size === [...str].length;


console.log(isUnique('😜'));
console.log(isUnique('😜😜'));

function isUnique(str) 
 return new Set(str).size === [...str].length;


console.log(isUnique('😜'));
console.log(isUnique('😜😜'));

share|improve this answer

edited Apr 3 at 6:03

Patrick Roberts

21.3k33777

answered Apr 3 at 5:37

CertainPerformanceCertainPerformance

100k166291

edited Apr 3 at 6:03

Patrick Roberts

21.3k33777

edited Apr 3 at 6:03

Patrick Roberts

21.3k33777

answered Apr 3 at 5:37

CertainPerformanceCertainPerformance

100k166291

answered Apr 3 at 5:37

CertainPerformanceCertainPerformance

100k166291

0

Only first iteration in your for loop is run (because you always execute 'return'). Instead you can use following code

function isUnique(str, t=) 
 
 return ![...str].some(c=> t[c]=c in t)


console.log('heloworld =>',isUnique('heloworld'));
console.log('helo =>',isUnique('helo'));

share|improve this answer

edited Apr 3 at 8:07

answered Apr 3 at 5:52

Kamil KiełczewskiKamil Kiełczewski

14.5k87397

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  Why is r a parameter?
  
  – JollyJoker
  Apr 3 at 8:01
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  r (I rename it to t) is temporary hash map (define in tricky way as default param)
  
  – Kamil Kiełczewski
  Apr 3 at 8:07
  
  

  
  
  
  

add a comment | 

0

Only first iteration in your for loop is run (because you always execute 'return'). Instead you can use following code

function isUnique(str, t=) 
 
 return ![...str].some(c=> t[c]=c in t)


console.log('heloworld =>',isUnique('heloworld'));
console.log('helo =>',isUnique('helo'));

share|improve this answer

edited Apr 3 at 8:07

answered Apr 3 at 5:52

Kamil KiełczewskiKamil Kiełczewski

14.5k87397

• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  Why is r a parameter?
  
  – JollyJoker
  Apr 3 at 8:01
  

  
  
  
  


• 
  
  
  

  
  

  
  
  
  
  
  

  
  
  r (I rename it to t) is temporary hash map (define in tricky way as default param)
  
  – Kamil Kiełczewski
  Apr 3 at 8:07
  
  

  
  
  
  

add a comment | 

Only first iteration in your for loop is run (because you always execute 'return'). Instead you can use following code

function isUnique(str, t=) 
 
 return ![...str].some(c=> t[c]=c in t)


console.log('heloworld =>',isUnique('heloworld'));
console.log('helo =>',isUnique('helo'));

share|improve this answer

edited Apr 3 at 8:07

answered Apr 3 at 5:52

Kamil KiełczewskiKamil Kiełczewski

14.5k87397

function isUnique(str, t=) 
 
 return ![...str].some(c=> t[c]=c in t)


console.log('heloworld =>',isUnique('heloworld'));
console.log('helo =>',isUnique('helo'));

function isUnique(str, t=) 
 
 return ![...str].some(c=> t[c]=c in t)


console.log('heloworld =>',isUnique('heloworld'));
console.log('helo =>',isUnique('helo'));

function isUnique(str, t=) 
 
 return ![...str].some(c=> t[c]=c in t)


console.log('heloworld =>',isUnique('heloworld'));
console.log('helo =>',isUnique('helo'));

share|improve this answer

edited Apr 3 at 8:07

answered Apr 3 at 5:52

Kamil KiełczewskiKamil Kiełczewski

14.5k87397

answered Apr 3 at 5:52

Kamil KiełczewskiKamil Kiełczewski

14.5k87397

answered Apr 3 at 5:52

Kamil KiełczewskiKamil Kiełczewski

14.5k87397