Trjtdtk

Hostile work environment after whistle-blowing on coworker and our boss. What do I do?

How to open new tab in existing terminal instead of new terminal instance?

What should I use for Mishna study?

What does this horizontal bar at the first measure mean?

Reply ‘no position’ while the job posting is still there (‘HiWi’ position in Germany)

How to create an folder path alias on ubuntu EC2 instance?

Is it possible to build a CPA Secure encryption scheme which remains secure even when the encryption of secret key is given?

Why isn't KTEX's runway designation 10/28 instead of 9/27?

What is the term when two people sing in harmony, but they aren't singing the same notes?

Organic chemistry Iodoform Reaction

What is the opposite of 'gravitas'?

Modern Day Chaucer

Drawing ramified coverings with tikz

What is the smallest body in which a sling shot maneuver can be performed?

Giant Toughroad SLR 2 for 200 miles in two days, will it make it?

General topology proving something for all of its points

How do I extrude a face to a single vertex

Visiting the UK as unmarried couple

does this mean what I think it means - 4th last time

Can an arcane focus boost spell attack or damage rolls?

Getting the lowest value with key in array

Did US corporations pay demonstrators in the German demonstrations against article 13?

Can a controlled ghast be a leader of a pack of ghouls?

Do Legal Documents Require Signing In Standard Pen Colors?

Extracting numeric values from a string containing key:value pairs

Simplify splitting a String into alpha and numeric partsRegex to remove inline javascript from stringExtraction of numbers from currency stringRemoving nested blocks from a stringExtracting tuples from Excel sheetRegex to obtain float values from a large text fileExtracting JSON from string using regexExtracting an IP address from a hosts file by hostnameExtracting parts of filenames from an arrayExtracting parameters from request URL path components using regexes

5

$begingroup$

I am writing function numericValues(text: String): List[Int] to extract patterns """([a-z]+)s*:s*(d+)""" and return the list of the numeric values :

numericValues("a123 : 0 abc:123 123:abc xyz:1") // List(123, 1)

I would write numericValues like this:

def numericValues(text: String): List[Int] = 
 val regex = """([a-z]+)s*:s*(d+)""".r
 regex.findAllIn(text).toList.flatMap s =>
 PartialFunction.condOpt(s) case regex(_, num) => num.toInt 
 

I guess the condOpt invocation is redundant and I wonder how to simplify this implementation. Also, I'd appreciate comments on improvements to style and best practice.

regex scala

share|improve this question

edited Mar 20 at 21:30

Michael

asked Mar 20 at 10:20

MichaelMichael

1285

New contributor

Michael is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

add a comment | 

5

$begingroup$

I am writing function numericValues(text: String): List[Int] to extract patterns """([a-z]+)s*:s*(d+)""" and return the list of the numeric values :

numericValues("a123 : 0 abc:123 123:abc xyz:1") // List(123, 1)

I would write numericValues like this:

def numericValues(text: String): List[Int] = 
 val regex = """([a-z]+)s*:s*(d+)""".r
 regex.findAllIn(text).toList.flatMap s =>
 PartialFunction.condOpt(s) case regex(_, num) => num.toInt 
 

I guess the condOpt invocation is redundant and I wonder how to simplify this implementation. Also, I'd appreciate comments on improvements to style and best practice.

regex scala

share|improve this question

edited Mar 20 at 21:30

Michael

asked Mar 20 at 10:20

MichaelMichael

1285

New contributor

Michael is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

add a comment | 

$begingroup$

I am writing function numericValues(text: String): List[Int] to extract patterns """([a-z]+)s*:s*(d+)""" and return the list of the numeric values :

numericValues("a123 : 0 abc:123 123:abc xyz:1") // List(123, 1)

I would write numericValues like this:

def numericValues(text: String): List[Int] = 
 val regex = """([a-z]+)s*:s*(d+)""".r
 regex.findAllIn(text).toList.flatMap s =>
 PartialFunction.condOpt(s) case regex(_, num) => num.toInt 
 

I guess the condOpt invocation is redundant and I wonder how to simplify this implementation. Also, I'd appreciate comments on improvements to style and best practice.

regex scala

share|improve this question

edited Mar 20 at 21:30

Michael

asked Mar 20 at 10:20

MichaelMichael

1285

New contributor

Michael is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

$endgroup$

numericValues("a123 : 0 abc:123 123:abc xyz:1") // List(123, 1)

def numericValues(text: String): List[Int] = 
 val regex = """([a-z]+)s*:s*(d+)""".r
 regex.findAllIn(text).toList.flatMap s =>
 PartialFunction.condOpt(s) case regex(_, num) => num.toInt 
 

share|improve this question

edited Mar 20 at 21:30

Michael

asked Mar 20 at 10:20

MichaelMichael

1285

New contributor

Michael is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

share|improve this question

edited Mar 20 at 21:30

Michael

asked Mar 20 at 10:20

MichaelMichael

1285

New contributor

Michael is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

asked Mar 20 at 10:20

MichaelMichael

1285

New contributor

Michael is a new contributor to this site. Take care in asking for clarification, commenting, and answering.
Check out our Code of Conduct.

asked Mar 20 at 10:20

MichaelMichael

1285

1 Answer
1

active

oldest

votes

7

$begingroup$

You usually want a zero-width word boundary b on either end of the regex, to avoid matching things like 1a:1a.

There's no need to capture [a-z]+ since you are throwing it away.

You can use lookbehind (?<=…) assertions to require a match to be preceded by whatever, without including the whatever in the match result. This means no need for capturing parenthesis, only the integer is included in the match, and the final map is simply _.toInt. Variable-width lookbehind was introduced in Java 9; older versions have only fixed-width lookbehind.

Finally, removing the variable makes braces unnecessary.

def numericValues(text: String): List[Int] = """(?<=b[a-z]+s*:s*)d+b""".r.findAllIn(text).toList.map(_.toInt)

With only fixed-width lookbehind, you could postprocess the matches to remove non-numerics:

….map(_.replaceAll("[^0-9]", "").toInt)

Or, more idiomatically and less hacky, just capture the digits and extract the capture groups:

"""b[a-z]+s*:s*(d+)b""".r.findAllIn(text).matchData.toList.map(_.group(1).toInt)

share|improve this answer

edited Mar 20 at 13:54

answered Mar 20 at 12:35

Oh My GoodnessOh My Goodness

1,799314

$endgroup$

• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  Thanks a lot. What if I have only fixed-width lookbehind ?
  $endgroup$
  – Michael
  Mar 20 at 13:00
  

  
  
  
  


• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  $begingroup$
  then you can't use variable-width lookbehind :) See edit.
  $endgroup$
  – Oh My Goodness
  Mar 20 at 13:56
  

  
  
  
  

add a comment | 

Your Answer

StackExchange.ifUsing("editor", function ()
return StackExchange.using("mathjaxEditing", function ()
StackExchange.MarkdownEditor.creationCallbacks.add(function (editor, postfix)
StackExchange.mathjaxEditing.prepareWmdForMathJax(editor, postfix, [["\$", "\$"]]);
);
);
, "mathjax-editing");

StackExchange.ifUsing("editor", function ()
StackExchange.using("externalEditor", function ()
StackExchange.using("snippets", function ()
StackExchange.snippets.init();
);
);
, "code-snippets");

StackExchange.ready(function()
var channelOptions =
tags: "".split(" "),
id: "196"
;
initTagRenderer("".split(" "), "".split(" "), channelOptions);

StackExchange.using("externalEditor", function()
// Have to fire editor after snippets, if snippets enabled
if (StackExchange.settings.snippets.snippetsEnabled)
StackExchange.using("snippets", function()
createEditor();
);

else
createEditor();

);

function createEditor()
StackExchange.prepareEditor(
heartbeatType: 'answer',
autoActivateHeartbeat: false,
convertImagesToLinks: false,
noModals: true,
showLowRepImageUploadWarning: true,
reputationToPostImages: null,
bindNavPrevention: true,
postfix: "",
imageUploader:
brandingHtml: "Powered by u003ca class="icon-imgur-white" href="https://imgur.com/"u003eu003c/au003e",
contentPolicyHtml: "User contributions licensed under u003ca href="https://creativecommons.org/licenses/by-sa/3.0/"u003ecc by-sa 3.0 with attribution requiredu003c/au003e u003ca href="https://stackoverflow.com/legal/content-policy"u003e(content policy)u003c/au003e",
allowUrls: true
,
onDemand: true,
discardSelector: ".discard-answer"
,immediatelyShowMarkdownHelp:true
);



);

Michael is a new contributor. Be nice, and check out our Code of Conduct.

draft saved

draft discarded

Sign up or log in

StackExchange.ready(function ()
StackExchange.helpers.onClickDraftSave('#login-link');
);

Sign up using Google

Sign up using Facebook

Sign up using Email and Password

Post as a guest

Name

Email

Required, but never shown

StackExchange.ready(
function ()
StackExchange.openid.initPostLogin('.new-post-login', 'https%3a%2f%2fcodereview.stackexchange.com%2fquestions%2f215831%2fextracting-numeric-values-from-a-string-containing-keyvalue-pairs%23new-answer', 'question_page');

);

Post as a guest

Name

Email

Required, but never shown

7

$begingroup$

You usually want a zero-width word boundary b on either end of the regex, to avoid matching things like 1a:1a.

There's no need to capture [a-z]+ since you are throwing it away.

You can use lookbehind (?<=…) assertions to require a match to be preceded by whatever, without including the whatever in the match result. This means no need for capturing parenthesis, only the integer is included in the match, and the final map is simply _.toInt. Variable-width lookbehind was introduced in Java 9; older versions have only fixed-width lookbehind.

Finally, removing the variable makes braces unnecessary.

def numericValues(text: String): List[Int] = """(?<=b[a-z]+s*:s*)d+b""".r.findAllIn(text).toList.map(_.toInt)

With only fixed-width lookbehind, you could postprocess the matches to remove non-numerics:

….map(_.replaceAll("[^0-9]", "").toInt)

Or, more idiomatically and less hacky, just capture the digits and extract the capture groups:

"""b[a-z]+s*:s*(d+)b""".r.findAllIn(text).matchData.toList.map(_.group(1).toInt)

share|improve this answer

edited Mar 20 at 13:54

answered Mar 20 at 12:35

Oh My GoodnessOh My Goodness

1,799314

$endgroup$

• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  Thanks a lot. What if I have only fixed-width lookbehind ?
  $endgroup$
  – Michael
  Mar 20 at 13:00
  

  
  
  
  


• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  $begingroup$
  then you can't use variable-width lookbehind :) See edit.
  $endgroup$
  – Oh My Goodness
  Mar 20 at 13:56
  

  
  
  
  

add a comment | 

7

$begingroup$

You usually want a zero-width word boundary b on either end of the regex, to avoid matching things like 1a:1a.

There's no need to capture [a-z]+ since you are throwing it away.

You can use lookbehind (?<=…) assertions to require a match to be preceded by whatever, without including the whatever in the match result. This means no need for capturing parenthesis, only the integer is included in the match, and the final map is simply _.toInt. Variable-width lookbehind was introduced in Java 9; older versions have only fixed-width lookbehind.

Finally, removing the variable makes braces unnecessary.

def numericValues(text: String): List[Int] = """(?<=b[a-z]+s*:s*)d+b""".r.findAllIn(text).toList.map(_.toInt)

With only fixed-width lookbehind, you could postprocess the matches to remove non-numerics:

….map(_.replaceAll("[^0-9]", "").toInt)

Or, more idiomatically and less hacky, just capture the digits and extract the capture groups:

"""b[a-z]+s*:s*(d+)b""".r.findAllIn(text).matchData.toList.map(_.group(1).toInt)

share|improve this answer

edited Mar 20 at 13:54

answered Mar 20 at 12:35

Oh My GoodnessOh My Goodness

1,799314

$endgroup$

• 
  
  
  

  
  

  
  
  
  
  
  

  
  $begingroup$
  Thanks a lot. What if I have only fixed-width lookbehind ?
  $endgroup$
  – Michael
  Mar 20 at 13:00
  

  
  
  
  


• 
  
  
  

  
  1
  

  
  
  
  
  
  

  
  $begingroup$
  then you can't use variable-width lookbehind :) See edit.
  $endgroup$
  – Oh My Goodness
  Mar 20 at 13:56
  

  
  
  
  

add a comment | 

$begingroup$

You usually want a zero-width word boundary b on either end of the regex, to avoid matching things like 1a:1a.

There's no need to capture [a-z]+ since you are throwing it away.

You can use lookbehind (?<=…) assertions to require a match to be preceded by whatever, without including the whatever in the match result. This means no need for capturing parenthesis, only the integer is included in the match, and the final map is simply _.toInt. Variable-width lookbehind was introduced in Java 9; older versions have only fixed-width lookbehind.

Finally, removing the variable makes braces unnecessary.

def numericValues(text: String): List[Int] = """(?<=b[a-z]+s*:s*)d+b""".r.findAllIn(text).toList.map(_.toInt)

With only fixed-width lookbehind, you could postprocess the matches to remove non-numerics:

….map(_.replaceAll("[^0-9]", "").toInt)

Or, more idiomatically and less hacky, just capture the digits and extract the capture groups:

"""b[a-z]+s*:s*(d+)b""".r.findAllIn(text).matchData.toList.map(_.group(1).toInt)

share|improve this answer

edited Mar 20 at 13:54

answered Mar 20 at 12:35

Oh My GoodnessOh My Goodness

1,799314

$endgroup$

def numericValues(text: String): List[Int] = """(?<=b[a-z]+s*:s*)d+b""".r.findAllIn(text).toList.map(_.toInt)

….map(_.replaceAll("[^0-9]", "").toInt)

"""b[a-z]+s*:s*(d+)b""".r.findAllIn(text).matchData.toList.map(_.group(1).toInt)

share|improve this answer

edited Mar 20 at 13:54

answered Mar 20 at 12:35

Oh My GoodnessOh My Goodness

1,799314

answered Mar 20 at 12:35

Oh My GoodnessOh My Goodness

1,799314

answered Mar 20 at 12:35

Oh My GoodnessOh My Goodness

1,799314